Fix _scheme_rmvm_rmdisk_only with canary=filter. Add new 'noop' redeploy scheme '_noredeploy_scale_in_only' #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loy scheme '_noredeploy_scale_in_only'
+ New scheme '_noredeploy_scale_in_only'
+ A special 'no-redeploy' scheme, which scales-in a cluster without needing to redeploy every node.
+ For each node in the cluster { run `predeleterole` on the node; shut down the node}
+ _scheme_rmvm_rmdisk_only with canary=filter was using undefined fields. Refactor to use cluster_hosts_state, and enable ability to downscale using this scheme.
flfernandez
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
predeleteroleon the node; shut down the node}