Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: data escaped space (+) was not parsing into space char. #68

Merged
merged 1 commit into from
Aug 12, 2023
Merged

fix: data escaped space (+) was not parsing into space char. #68

merged 1 commit into from
Aug 12, 2023

Conversation

skwasjer
Copy link
Owner

@skwasjer skwasjer commented Aug 12, 2023 •
edited
Loading

Spaces escaped as + sign should be parsed into space character allowing the form data matcher to pass.

Fixes #63

@skwasjer skwasjer changed the title fix: data escaped space (+) was not parsing space char correctly. fix: data escaped space (+) was not parsing into space char correctly. Aug 12, 2023
@skwasjer skwasjer changed the title fix: data escaped space (+) was not parsing into space char correctly. fix: data escaped space (+) was not parsing into space char. Aug 12, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 12, 2023 •
edited
Loading

Codecov Report

Merging #68 (3523dcb) into main (45b8ebe) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Files Changed Coverage Δ
src/MockHttp/Http/DataEscapingHelper.cs 87.75% <100.00%> (+0.25%) ⬆️

... and 1 file with indirect coverage changes

@skwasjer skwasjer merged commit a8870d7 into main Aug 12, 2023
10 checks passed
@skwasjer skwasjer deleted the bugfix/space_data_escaping branch August 12, 2023 15:27
skwasjer added a commit that referenced this pull request Aug 13, 2023
@skwasjer
fix: data escaped + (plus) was not parsed correctly.
ff53ce1 
Caused by: #68
@skwasjer skwasjer added the bug Something isn't working label Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

not working with FormUrlEncodedContent
1 participant
@skwasjer