test: disable xunit's AppDomain which seems to have been causing the …

…issue with random CI failures (on mono). (#126)
skwasjer · Oct 6, 2024 · dca42eb · dca42eb
1 parent 8590457
commit dca42eb
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 30 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -122,9 +122,9 @@ jobs:
           name: build
 
       # Run all tests
-      - run: dotnet test --no-restore --no-build -c Release
+      - run: dotnet test --no-restore --no-build -c Release -- xUnit.AppDomain=denied
         if: matrix.os == 'ubuntu-latest'
-      - run: dotnet test --no-restore --no-build -c Release --filter Category!=PublicApi
+      - run: dotnet test --no-restore --no-build -c Release --filter Category!=PublicApi -- xUnit.AppDomain=denied
         if: matrix.os != 'ubuntu-latest'
 
   pack:

diff --git a/.github/workflows/sonarcloud.yml b/.github/workflows/sonarcloud.yml
@@ -81,6 +81,6 @@ jobs:
         run: |
           dotnet sonarscanner begin /k:"$SONAR_PROJECT_KEY" /o:"$SONAR_ORG_KEY" /d:sonar.host.url=https://sonarcloud.io /d:sonar.token="$SONAR_TOKEN" /d:sonar.cs.opencover.reportsPaths="**/*opencover.xml" $SONAR_PR_ARGS
 
-          dotnet test -c Release /p:CollectCoverage=true /p:CoverletOutputFormat=opencover /p:ExcludeByFile="test/**/*.cs" /p:VerifyPublicApi=false
+          dotnet test -c Release /p:CollectCoverage=true /p:CoverletOutputFormat=opencover /p:ExcludeByFile="test/**/*.cs" /p:VerifyPublicApi=false -- xUnit.AppDomain=denied
 
           dotnet sonarscanner end /d:sonar.token="$SONAR_TOKEN"
diff --git a/test/MockHttp.Json.Tests/MockHttp.Json.Tests.csproj b/test/MockHttp.Json.Tests/MockHttp.Json.Tests.csproj
@@ -8,10 +8,6 @@
     <RootNamespace>MockHttp.Json</RootNamespace>
   </PropertyGroup>
 
-  <ItemGroup>
-    <Compile Include="..\MockHttp.Testing\XunitAppDomainUnloadHook.cs" Link="XunitAppDomainUnloadHook.cs" />
-  </ItemGroup>
-
   <ItemGroup>
     <ProjectReference Include="..\MockHttp.Testing\MockHttp.Testing.csproj" />
     <!-- For coverage purposes, override default dependency resolution and instead target specific frameworks. -->

diff --git a/test/MockHttp.Server.Tests/MockHttp.Server.Tests.csproj b/test/MockHttp.Server.Tests/MockHttp.Server.Tests.csproj
@@ -8,10 +8,6 @@
     <RootNamespace>MockHttp</RootNamespace>
   </PropertyGroup>
 
-  <ItemGroup>
-    <Compile Include="..\MockHttp.Testing\XunitAppDomainUnloadHook.cs" Link="XunitAppDomainUnloadHook.cs" />
-  </ItemGroup>
-
   <ItemGroup>
     <PackageReference Include="Microsoft.Extensions.Diagnostics.Testing" Version="8.9.1" />
   </ItemGroup>

diff --git a/test/MockHttp.Testing/XunitAppDomainUnloadHook.cs b/test/MockHttp.Testing/XunitAppDomainUnloadHook.cs
diff --git a/test/MockHttp.Tests/MockHttp.Tests.csproj b/test/MockHttp.Tests/MockHttp.Tests.csproj
@@ -8,10 +8,6 @@
     <RootNamespace>MockHttp</RootNamespace>
   </PropertyGroup>
 
-  <ItemGroup>
-    <Compile Include="..\MockHttp.Testing\XunitAppDomainUnloadHook.cs" Link="XunitAppDomainUnloadHook.cs" />
-  </ItemGroup>
-
   <ItemGroup>
     <ProjectReference Include="..\MockHttp.Testing\MockHttp.Testing.csproj" />
     <!-- For coverage purposes, override default dependency resolution and instead target specific frameworks. -->