Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check that token filename is not a directory #1884

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Add check that token filename is not a directory #1884

merged 1 commit into from
Jan 17, 2025

Conversation

lynnemorrison
Copy link
Collaborator

check that filename is not a directory and warn on failure

fixes #1858

@lynnemorrison lynnemorrison self-assigned this Jan 15, 2025
ajssmith
ajssmith approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@ajssmith ajssmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nluaces
nluaces approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@nluaces nluaces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@nluaces nluaces linked an issue Jan 16, 2025 that may be closed by this pull request
'skupper token issue' behavior when <filename> is a directory #1858
Closed
@nluaces nluaces merged commit 9d4b2c1 into skupperproject:main Jan 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nluaces nluaces nluaces approved these changes

@ajssmith ajssmith ajssmith approved these changes

Assignees

@lynnemorrison lynnemorrison

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'skupper token issue' behavior when <filename> is a directory
3 participants
@lynnemorrison @ajssmith @nluaces