[v1] Add sourceHost and destHost to flow metrics (with improvements) #1854
Conversation
This change adds sourceHost and destHost to the flow metrics produced by the flow collector. It acomplishes this by adding those labels to the promethus metrics, and changing the aggregation key for metric aggreagation in the flow collector. This approach may change to one that does not require new labels on the prometheus metric. To be discussed.
Fix to populate destHost label correctly in revLabels
|
Hi @ajssmith @c-kruse When you have a minute, I had a question on the 2 minute wait that I noticed in needForSiteProcess. I was just curious why a 2 minute wait is needed here... Btw, as a next step, I'll work on an approach that does not add new labels. Thanks, Karen |
Karen-Schoener
changed the title
|
@Karen-Schoener, Andy probably has a better answer for you here, but I believe that delay is intended to guard against the collector prematurely associating flows with a site-process or site-client when a new process record could be en-route from a controller. One hundred and twenty seconds is probably a bit much, but the collector very much receives vanflow messages in wild orders (especially from different event sources - like is the case with ProcessRecords and FlowRecords which come from the "Controller" part of pkg/flow and FlowRecords that come from the skupper router.) Because these site server and site client processes hang around (don't tend to get cleaned up until the site goes away), and because flow pairs get permanently associated with the process, we were trying to be careful to avoid this. |
Fixed an issue with PR #1824.
Tested skupper console with this fix.
Tested with external vm-client and external vm-server.
Verified that in/out metrics displayed as expected in the skupper console.
Tested with hello-world frontend/backend deployments.
Verified that in/out metrics displayed as expected in the skupper console.