add support for nonkube site delete --all option #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynnemorrison
force-pushed
the
v2_nonkube_delete
branch
from
cfede53 to
13f1de6
Compare
fgiorgetti
reviewed
Dec 17, 2024
| @@ -85,6 +91,28 @@ func (cmd *CmdSiteDelete) Run() error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| // if delete all, also remove all the other resources | |||
| if cmd.all { | |||
There was a problem hiding this comment.
What if there are AccessTokens or Links to other sites?
Would it be fair to remove all resources from the input/resources instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.