Collector logging #1828
Merged
Collector logging #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example network-observer startup logs with |
Signed-off-by: Christian Kruse <[email protected]>
Implements several "profiles" to control the quantity of vanflow record logging the collector does. Defaults to silent. Primairly a debugging aid. Signed-off-by: Christian Kruse <[email protected]>
Convert record map into slog.Group Signed-off-by: Christian Kruse <[email protected]>
c-kruse
force-pushed
the
collector-logging
branch
from
f42685e to
58271df
Compare
fgiorgetti
reviewed
Dec 13, 2024
cmd/network-observer/profiles.go
Outdated
| Match: flowlog.NewRecordTypeSet( | ||
| vanflow.SiteRecord{}, vanflow.RouterRecord{}, | ||
| vanflow.ProcessRecord{}, vanflow.ConnectorRecord{}, | ||
| vanflow.LinkRecord{}, vanflow.ListenerRecord{}, |
There was a problem hiding this comment.
Should LinkRecord be part of both rules (priority 5 and 1)?
There was a problem hiding this comment.
Ah, there was no real sense in that. Dropped it from the p 5 rule (lowest wins). Thank you!
fgiorgetti
approved these changes
Dec 13, 2024
Signed-off-by: Christian Kruse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopens #1783
I believe we've sorted out that this sort of a protocol-level vanflow logging option is useful for debugging different scenarios, but is not a particularly nice solution for users looking for an audit trail for service traffic. I've opened #1827 to tackle that use case.