Fix the early parsing of platform flag in init() #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabordozsa
force-pushed
the
fix_#1147_platform_flag_parsing
branch
from
906d137 to
809a0b6
Compare
Fixes skupperproject#1147 Signed-off-by: Gabor Dozsa <[email protected]>
gabordozsa
force-pushed
the
fix_#1147_platform_flag_parsing
branch
from
809a0b6 to
4f6fb12
Compare
|
I believe it also fixes #1312. |
fgiorgetti
requested review from
grs,
ajssmith,
nluaces,
fgiorgetti and
c-kruse
grs
approved these changes
Apr 23, 2024
fgiorgetti
approved these changes
Apr 23, 2024
nluaces
approved these changes
Apr 24, 2024
c-kruse
approved these changes
Apr 25, 2024
ajssmith
approved these changes
Apr 30, 2024
nluaces
pushed a commit
that referenced
this pull request
Jun 7, 2024
Fixes #1147 Signed-off-by: Gabor Dozsa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parsing of
--platformhappens very early in theinit()in order to decide which type of client to instantiate. However, no other flags are defined yet at that point. This causes the parsing to fail if any other flag is encountered in the command line before the--platformone (and the code then falls back to the default Kubernetes platform).Fixes #1147