Fixes displaying of podman sites recommandation #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fgiorgetti
commented
Dec 13, 2023
fgiorgetti
commented
- A recommendation message has to be displayed when podman endpoint is not available
- Previously the recommendation message was just displayed during init
- Unit tests added to cover NewClient (for podman)
grs
approved these changes
Dec 13, 2023
nluaces
approved these changes
Dec 13, 2023
c-kruse
approved these changes
Dec 13, 2023
fgiorgetti
force-pushed
the
podman-recommendation-fix
branch
from
315558d to
ec64bb6
Compare
fgiorgetti
force-pushed
the
podman-recommendation-fix
branch
from
ec64bb6 to
9c55829
Compare
nluaces
pushed a commit
that referenced
this pull request
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.