Update policy status on CRD creation/removal #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to do some testing first, but hope this fixes #1291. |
c-kruse
force-pushed
the
fix/update-policy-status
branch
from
45abe2e to
dc72039
Compare
Issue skupperproject#1291 Updates the flow controller to periodically poll for changes to the skupper policy CRD, and to send a flow record to update the site. Changes the collector to update network status when an update to a site is detected. Signed-off-by: c-kruse <[email protected]>
c-kruse
force-pushed
the
fix/update-policy-status
branch
from
dc72039 to
9e1dc84
Compare
c-kruse
changed the title
|
Would appreciate someone else doing a manual end to end test on this, or maybe better yet pairing with me on that. It appears to work as I would expect when isolated, but when it was hooked up to multiple sites and services there was a bit of drama after adding the CRDs. I think it may just be the way policies behave, but want to be sure this isn't introducing any bad behavior. |
fgiorgetti
reviewed
Dec 5, 2023
There was a problem hiding this comment.
A couple of minor comments, but overall it seems to work fine.
Nice job @c-kruse !
Signed-off-by: Christian Kruse <[email protected]>
nluaces
approved these changes
Dec 5, 2023
fgiorgetti
approved these changes
Dec 5, 2023
nluaces
pushed a commit
that referenced
this pull request
Dec 6, 2023
Updates the flow controller to periodically poll for changes to the skupper policy CRD, and to send a flow record to update the site. Changes the collector to update network status when an update to a site is detected. Closes issue 1291
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1291
Updates the flow controller to periodically poll for changes to the
skupper policy CRD, and to send a flow record to update the site.
Changes the collector to update network status when an update to a site
is detected.