Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle error from spinner #1301

Merged
merged 2 commits into from
Dec 1, 2023
Merged

handle error from spinner #1301

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e42a9f
handle error from spinner
nluaces Dec 1, 2023
602fea7
modify message
nluaces Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cmd/skupper/skupper_kube_site.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ func (s *SkupperKubeSite) Platform() types.Platform {

func (s *SkupperKubeSite) Create(cmd *cobra.Command, args []string) error {
cli := s.kube.Cli

silenceCobra(cmd)
ns := cli.GetNamespace()

Expand Down Expand Up @@ -115,7 +114,7 @@ func (s *SkupperKubeSite) Create(cmd *cobra.Command, args []string) error {
})

if err != nil {
return err
fmt.Println("Skupper status is not loaded yet, it will be available in a few seconds")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nluaces This approach of displaying a message here, instead of returning an error, makes sense to me.
I am not sure if the message should say "it will be available in a few seconds".
Thoughts: @grs @c-kruse @ajssmith ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree; I would leave out that part.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fgiorgetti how about just "Skupper status is not loaded yet"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better to me. Thank you @nluaces.

}

fmt.Println("Skupper is now installed in namespace '" + ns + "'. Use 'skupper status' to get more information.")
Expand Down