Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimisation of service definition reconciliation loop #1128

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

grs
Copy link
Member

@grs grs commented May 26, 2023

Fixes #1124

@grs grs force-pushed the service-check-optimisation branch from abd16a1 to ee8d6d8 Compare May 30, 2023 09:20
@ajssmith ajssmith self-requested a review June 2, 2023 11:37
Copy link
Member

@ajssmith ajssmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tried locally and compared script execution prior and after. Improvement noted.

@ajssmith ajssmith requested a review from nluaces June 2, 2023 11:38
@grs grs force-pushed the service-check-optimisation branch from ee8d6d8 to c0d6ef7 Compare June 6, 2023 13:54
@fgiorgetti
Copy link
Member

I believe that updateActualServices can be removed now.

@grs grs force-pushed the service-check-optimisation branch from c0d6ef7 to 7add1a2 Compare June 7, 2023 19:30
@grs grs merged commit 826d37a into skupperproject:master Jun 12, 2023
@grs grs deleted the service-check-optimisation branch June 12, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service creation delay when creating many deployments in a short time
4 participants