Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve target type inference mechanism used by the policy controller #1439

Closed
fgiorgetti opened this issue Apr 15, 2024 · 0 comments · Fixed by #1442
Closed

Improve target type inference mechanism used by the policy controller #1439

fgiorgetti opened this issue Apr 15, 2024 · 0 comments · Fixed by #1442

Comments

@fgiorgetti
Copy link
Member

Describe the bug
If an existing service is exposed, using annotations only, the actual target are the
original selectors for that service and that is causing the mechanism to fail as it is
unable to determine the appropriate target type.

Along with that, the policy controller uses a mechanism to determine the target type
of a skupper service, by "guessing" what the type is, based on its exposed selectors,
or in case a target service (hostname) is used, then it assumes it is a service.

How To Reproduce

Enable policies, then through a Skupper Policy, allow only the exposure of a "deployment"
kind for your "my-service" resource name. Then expose an existing service, named my-service,
using annotations.

The policy controller will allow it to be exposed, as it is unable to infer the target type.

Expected behavior
Skupper should have an assertive way of determining the target type.

Environment details

  • Skupper CLI: 1.6.0
  • Platform: kubernetes, openshift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant