-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable s390x Travis CI build; Add coredump analyzer for Travis #654
Enable s390x Travis CI build; Add coredump analyzer for Travis #654
Conversation
https://app.travis-ci.com/github/jiridanek/skupper-router/jobs/578785860#L4657 That line is worrisome. All requirements for the test should be fulfulled! |
Somehow this function - https://github.com/skupperproject/skupper-router/blob/main/tests/system_tests_http2.py#L67 - is returning True, which is why the tests are being skipped. Surely something is wrong with one of those three functions. This might be unrelated but this function - https://github.com/skupperproject/skupper-router/blob/main/tests/system_tests_http2.py#L39 - never returns False |
I'll try debug it tomorrow. Find out what exactly is returning (not true). |
Thanks much @jiridanek |
a4bf430
to
99c86bb
Compare
The reason was the following, https://app.travis-ci.com/github/jiridanek/skupper-router/jobs/578900073#L298 The edit: but, workarounding ^^^ breaks my other workaround for s390x ;( |
So, currently, there is only a single real issue as far as I can tell |
Codecov Report
@@ Coverage Diff @@
## main #654 +/- ##
=======================================
Coverage 25.90% 25.90%
=======================================
Files 128 128
Lines 31195 31195
Branches 4973 4973
=======================================
Hits 8081 8081
Misses 22059 22059
Partials 1055 1055
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bc56641
to
b15b51e
Compare
https://app.travis-ci.com/github/jiridanek/skupper-router/builds/254021857
Looks like we have to live with the default pattern, which seems to be
core
.The working of the coredump analysis can be tested by replacing the CI script with