Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable s390x Travis CI build; Add coredump analyzer for Travis #654

Merged

Conversation

jiridanek
Copy link
Contributor

https://app.travis-ci.com/github/jiridanek/skupper-router/builds/254021857

$ sudo sysctl -w kernel.core_pattern="coredump.%e.%p"
sysctl: permission denied on key "kernel.core_pattern"

Looks like we have to live with the default pattern, which seems to be core.

The working of the coredump analysis can be tested by replacing the CI script with

python3 -c 'import os; import signal; os.kill(os.getpid(), signal.SIGABRT)'

@jiridanek jiridanek added this to the 2.1.0 milestone Aug 4, 2022
@jiridanek jiridanek self-assigned this Aug 4, 2022
@jiridanek
Copy link
Contributor Author

60: test_get_image_jpg (system_tests_http2_tls.Http2TestTlsStandaloneRouter) ... skipped 'Python 3.7 or greater, Quart 0.13.0 or greater and curl needed to run http2 tests'

https://app.travis-ci.com/github/jiridanek/skupper-router/jobs/578785860#L4657

That line is worrisome. All requirements for the test should be fulfulled!

@ganeshmurthy
Copy link
Contributor

ganeshmurthy commented Aug 4, 2022

60: test_get_image_jpg (system_tests_http2_tls.Http2TestTlsStandaloneRouter) ... skipped 'Python 3.7 or greater, Quart 0.13.0 or greater and curl needed to run http2 tests'

https://app.travis-ci.com/github/jiridanek/skupper-router/jobs/578785860#L4657

That line is worrisome. All requirements for the test should be fulfulled!

Somehow this function - https://github.com/skupperproject/skupper-router/blob/main/tests/system_tests_http2.py#L67 - is returning True, which is why the tests are being skipped. Surely something is wrong with one of those three functions. This might be unrelated but this function - https://github.com/skupperproject/skupper-router/blob/main/tests/system_tests_http2.py#L39 - never returns False

@jiridanek
Copy link
Contributor Author

I'll try debug it tomorrow. Find out what exactly is returning (not true).

@ganeshmurthy
Copy link
Contributor

I'll try debug it tomorrow. Find out what exactly is returning (not true).

Thanks much @jiridanek

@jiridanek jiridanek force-pushed the jd_2022_08_02_travis.yml_requirements branch from a4bf430 to 99c86bb Compare August 5, 2022 13:10
@jiridanek
Copy link
Contributor Author

jiridanek commented Aug 5, 2022

I'll try debug it tomorrow. Find out what exactly is returning (not true).

Thanks much @jiridanek

The reason was the following, https://app.travis-ci.com/github/jiridanek/skupper-router/jobs/578900073#L298

The pip install was not updating jinja2 and markupsafe packages, because they were already installed systemwide. New version of quart did not work with the old versions of jinja2 or markupsafe. The return of None in the function to check Python version did not matter; None is falsey, so that works fine.

edit: but, workarounding ^^^ breaks my other workaround for s390x ;(

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2022

Codecov Report

Merging #654 (bc56641) into main (ed76bea) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #654   +/-   ##
=======================================
  Coverage   25.90%   25.90%           
=======================================
  Files         128      128           
  Lines       31195    31195           
  Branches     4973     4973           
=======================================
  Hits         8081     8081           
  Misses      22059    22059           
  Partials     1055     1055           
Flag Coverage Δ
unittests 25.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jiridanek jiridanek changed the title Fix various small issues with Travis CI build Enable s390x Travis CI build; Add coredump analyzer for Travis Aug 5, 2022
@jiridanek jiridanek force-pushed the jd_2022_08_02_travis.yml_requirements branch from bc56641 to b15b51e Compare August 5, 2022 17:55
@jiridanek jiridanek merged commit e6c90dd into skupperproject:main Aug 5, 2022
@jiridanek jiridanek deleted the jd_2022_08_02_travis.yml_requirements branch August 5, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants