Issue #371 - Add h2spec container test (inspired by qdr-image tests from @fgiorgetti)
#381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiridanek
commented
Apr 27, 2022
jiridanek
force-pushed
the
jd_2022_04_22_fernandos_container_tests
branch
2 times, most recently
from
f8e34b3 to
0d0d885
Compare
jiridanek
changed the title
h2spec container test (inspired by qdr tests from @fgiorgetti)h2spec container test (inspired by qdr-image tests from @fgiorgetti)
10 tasks
jiridanek
force-pushed
the
jd_2022_04_22_fernandos_container_tests
branch
2 times, most recently
from
81caacd to
8eb3b3f
Compare
jiridanek
force-pushed
the
jd_2022_04_22_fernandos_container_tests
branch
from
8eb3b3f to
87d9789
Compare
…-image tests from @fgiorgetti)
jiridanek
force-pushed
the
jd_2022_04_22_fernandos_container_tests
branch
from
87d9789 to
6ab9ff8
Compare
kgiusti
approved these changes
May 17, 2022
Codecov Report
@@ Coverage Diff @@
## main #381 +/- ##
==========================================
+ Coverage 25.04% 25.29% +0.24%
==========================================
Files 114 114
Lines 28609 28601 -8
Branches 4646 4648 +2
==========================================
+ Hits 7165 7234 +69
+ Misses 20487 20406 -81
- Partials 957 961 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@ganeshmurthy Added a comment with manual commands to run the test by hand in three terminal windows. I solemnly promise to be ready to triage any problems with the test that might appear, so that this test addition is not causing any extra work for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.