Migrate from rpkg to packit as rpkg is not available on CentOS Stream 9 #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixup remove changelog fixup remove changelog fixup remove changelog fixup remove changelog fixup remove changelog fixup remove changelog fixup remove changelog fixup remove changelog fixup remove changelog fixup remove changelog fixup remove changelog fixup remove changelog Migrate from rpkg to packit as rpkg is not available on centos 9 Migrate from rpkg to packit as rpkg is not available on centos 9 Build RPM on CentOS Stream 9 (build on CentOS 8 fails) Build RPM on CentOS Stream 9 (build on CentOS 8 fails) Build RPM on CentOS Stream 9 (build on CentOS 8 fails) Build RPM on CentOS Stream 9 (build on CentOS 8 fails) Build RPM on CentOS Stream 9 (build on CentOS 8 fails) Build RPM on CentOS Stream 9 (build on CentOS 8 fails)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1120 +/- ##
==========================================
+ Coverage 66.50% 71.91% +5.41%
==========================================
Files 318 208 -110
Lines 64589 51971 -12618
Branches 0 5574 +5574
==========================================
- Hits 42954 37377 -5577
+ Misses 21635 12009 -9626
- Partials 0 2585 +2585
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jiridanek
force-pushed
the
jd_2023_06_06_rpm_centos9
branch
from
9473256 to
0430f72
Compare
3 tasks
ganeshmurthy
approved these changes
Jun 7, 2023
jiridanek
changed the title
kgiusti
pushed a commit
to kgiusti/skupper-router
that referenced
this pull request
Jul 17, 2023
… 9 (skupperproject#1120) * use %{python3_sitelib}/ because listing individual files inside fails on CentOS/Fedora differences * build RPM on CentOS Stream 9 (build on CentOS 8 fails) * add openssl RPM dependency for running tests (cherry picked from commit 8bb17f7)
jiridanek
added a commit
to jiridanek/skupper-router
that referenced
this pull request
Sep 19, 2023
… 9 (skupperproject#1120) * use %{python3_sitelib}/ because listing individual files inside fails on CentOS/Fedora differences * build RPM on CentOS Stream 9 (build on CentOS 8 fails) * add openssl RPM dependency for running tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cannot simply change CentOS image from 8 to 9, because rpkg does not have packages for CentOS 9. That means upgrading to packit is required. See
and the links there for why packit is so awesome. (Mostly because it is the new hot thing that is getting tender love and care, as opposed to the older approaches that are left to rot.)
This PR is a lightweight version of
because it only uses packit to do local build and does not use the CI features.
edit: Looks like packit will run the CI tests on its own by default... well, that is nice bonus, right?