Fixes #1107 - Use a tiered list of read-grant amounts based on percen… #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ased on percentage of buffer capacity that's in use.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1110 +/- ##
==========================================
+ Coverage 77.90% 77.93% +0.02%
==========================================
Files 238 238
Lines 60656 60691 +35
Branches 5567 5678 +111
==========================================
+ Hits 47257 47297 +40
+ Misses 10775 10771 -4
+ Partials 2624 2623 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ganeshmurthy
reviewed
Jun 5, 2023
| @@ -111,7 +111,8 @@ static inline void *qd_alloc_deref_safe_ptr(const qd_alloc_safe_ptr_t *sp) | |||
| void free_##T(T *p); \ | |||
| typedef qd_alloc_safe_ptr_t T##_sp; \ | |||
| void set_safe_ptr_##T(T *p, T##_sp *sp); \ | |||
| T *safe_deref_##T(T##_sp sp) | |||
| T *safe_deref_##T(T##_sp sp); \ | |||
| qd_alloc_stats_t *alloc_stats_##T(void) | |||
There was a problem hiding this comment.
It would be nice if we could call this get_alloc_stats_##T instead of alloc_stats_##T
There was a problem hiding this comment.
Make this a separate issue. It was already there, I just added it to the declaration.
|
I think it is safe to suppress the race error, since this doesn't require synchronous access to the held_in_threads counter: |
kgiusti
reviewed
Jun 5, 2023
…e grant logic.
ganeshmurthy
reviewed
Jun 5, 2023
…e max-read-buffers from Proton.
ganeshmurthy
approved these changes
Jun 5, 2023
…cessing memory stats.
kgiusti
approved these changes
Jun 5, 2023
ganeshmurthy
pushed a commit
that referenced
this pull request
Jun 5, 2023
#1110) * Fixes #1107 - Use a tiered list of read-grant amounts based on percentage of buffer capacity that's in use. * Fixes #1107 - No logic changes - clarified intent of the grant logic. * Fixes #1107 - Fixed bug identified by kguisti. Infer the max-read-buffers from Proton. * Fixes #1107 - Renamed the env variable and added a log statement. * Fixes #1107 - Suppress the race warning (TSAN) while accessing memory stats. (cherry picked from commit 0489951)
jiridanek
pushed a commit
to jiridanek/skupper-router
that referenced
this pull request
Sep 19, 2023
…ased on percen… (skupperproject#1110) * Fixes skupperproject#1107 - Use a tiered list of read-grant amounts based on percentage of buffer capacity that's in use. * Fixes skupperproject#1107 - No logic changes - clarified intent of the grant logic. * Fixes skupperproject#1107 - Fixed bug identified by kguisti. Infer the max-read-buffers from Proton. * Fixes skupperproject#1107 - Renamed the env variable and added a log statement. * Fixes skupperproject#1107 - Suppress the race warning (TSAN) while accessing memory stats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tage of buffer capacity that's in use.