Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system_test_ssl spurious false test failure in test_ssl_client_profile_update #1683

Open
kgiusti opened this issue Nov 26, 2024 · 1 comment · Fixed by #1684
Open

system_test_ssl spurious false test failure in test_ssl_client_profile_update #1683

kgiusti opened this issue Nov 26, 2024 · 1 comment · Fixed by #1684
Assignees
Labels
test-bug It's a test bug unless proven otherwise

Comments

@kgiusti
Copy link
Contributor

kgiusti commented Nov 26, 2024

This test occasionally fails due to the lack of an exception expected to be thrown from the test client using the incorrect credentials.

However looking at the test client logs the ssl negotiation failed as expected, but apparently the exception does not get thrown.

The exception fails to be thrown by client FooRx3 here

But if we see the output logs from FooRx3 we can see that the ssl handshake did fail as expected:

root:system_test.py:2046 2024-11-25 21:01:50.557039 AsyncTestReceiver FooRx3: AsyncTestReceiver Starting reactor
proton:_reactor.py:1052 Connecting to Url('amqps://localhost:22445')...
root:system_test.py:2046 2024-11-25 21:01:50.571349 AsyncTestReceiver FooRx3: AsyncTestReceiver on_transport_error=SSL Failure: error:0A000086:SSL routines::certificate verify failed
root:system_test.py:2046 2024-11-25 21:01:50.571529 AsyncTestReceiver FooRx3: Disconnected
proton:_reactor.py:1104 Disconnected, already closed
root:system_test.py:2046 2024-11-25 21:01:50.572501 AsyncTestReceiver FooRx3: AsyncTestReceiver reactor thread done

Notice the expected certificate verify failed in the above, yet no exception was generated.

@kgiusti kgiusti added the test-bug It's a test bug unless proven otherwise label Nov 26, 2024
@kgiusti kgiusti self-assigned this Nov 26, 2024
kgiusti added a commit to kgiusti/skupper-router that referenced this issue Nov 26, 2024
This does not fix the issue but will give more detail should the error
happen again.
@kgiusti kgiusti linked a pull request Nov 26, 2024 that will close this issue
kgiusti added a commit that referenced this issue Nov 26, 2024
This does not fix the issue but will give more detail should the error
happen again.
@kgiusti
Copy link
Contributor Author

kgiusti commented Nov 26, 2024

Patch does not fix the issue: just adds more debug info in case it occurs again

@kgiusti kgiusti reopened this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-bug It's a test bug unless proven otherwise
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant