Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to VanFlow LINKs - Making them administrative #1456

Closed
ted-ross opened this issue Apr 2, 2024 · 0 comments · Fixed by #1540
Closed

Change to VanFlow LINKs - Making them administrative #1456

ted-ross opened this issue Apr 2, 2024 · 0 comments · Fixed by #1540
Assignees
@ted-ross
Milestone
3.0.0

Comments

@ted-ross
Copy link
Member

ted-ross commented Apr 2, 2024

Currently, the LINK record in VanFlow is operational. The records only exist when there is an open inter-router link in operation. There is no positive indication of the desire to have a link that may or may not be currently connected.

This change changes the semantics of LINK and adds a new record type ACCESS_POINT. These track link connectors and listeners respectively. LINK has an attribute called OPER_STATUS that is either "down" or "up" depending on whether the link is connected to a peer router or not. ACCESS_POINT has an attribute called LINK_COUNT that indicates the number of link connections that are connected inbound from peer routers.

Improvements:

  • These entities are administrative and follow the lifecycle of the configured listeners and connectors.
  • They handle edge links as well as inter-router links (currently, only inter-router links are shown).
@ted-ross ted-ross self-assigned this Apr 2, 2024
ted-ross added a commit to ted-ross/skupper-router that referenced this issue Apr 2, 2024
@ted-ross
Fixes skupperproject#1456 - Implemented the administrative ACCESS_POI…
5af9140 
…NT and LINK

This also separates the closure-of-all-connections from the freeing of the server module so that connections can be closed at an earlier point of the shutdown sequence.

This also adds accepted-connections to the listener reference counts for a more orderly freeing of resources.
ted-ross added a commit to ted-ross/skupper-router that referenced this issue Apr 4, 2024
@ted-ross
Fixes skupperproject#1456 - Implemented the administrative ACCESS_POI…
6e33dc3 
…NT and LINK

This also separates the closure-of-all-connections from the freeing of the server module so that connections can be closed at an earlier point of the shutdown sequence.

This also adds accepted-connections to the listener reference counts for a more orderly freeing of resources.
ted-ross added a commit to ted-ross/skupper-router that referenced this issue Apr 16, 2024
@ted-ross
Fixes skupperproject#1456 - Implemented the administrative ACCESS_POI…
be4f604 
…NT and LINK

This also separates the closure-of-all-connections from the freeing of the server module so that connections can be closed at an earlier point of the shutdown sequence.

This also adds accepted-connections to the listener reference counts for a more orderly freeing of resources.
kgiusti pushed a commit to kgiusti/skupper-router that referenced this issue Jun 20, 2024
@ted-ross @kgiusti
Fixes skupperproject#1456 - Implemented the administrative ACCESS_POI…
0112c8d 
…NT and LINK

This also separates the closure-of-all-connections from the freeing of the server module so that connections can be closed at an earlier point of the shutdown sequence.

This also adds accepted-connections to the listener reference counts for a more orderly freeing of resources.
kgiusti pushed a commit to kgiusti/skupper-router that referenced this issue Jul 2, 2024
@ted-ross @kgiusti
Fixes skupperproject#1456 - Implemented the administrative ACCESS_POI…
c1f1c96 
…NT and LINK

This also separates the closure-of-all-connections from the freeing of the server module so that connections can be closed at an earlier point of the shutdown sequence.

This also adds accepted-connections to the listener reference counts for a more orderly freeing of resources.

Original work by Ted Ross. Ported to amqp adaptor and obfuscated by kgiusti
@kgiusti kgiusti linked a pull request Jul 2, 2024 that will close this issue
Fixes #1456 - Implemented the administrative ACCESS_POINT and LINK #1540
Merged
kgiusti added a commit that referenced this issue Jul 3, 2024
@kgiusti @ted-ross
Fixes #1456 - Implemented the administrative ACCESS_POINT and LINK (#…
bce7f42 
…1540)

* Fixes #1456 - Implemented the administrative ACCESS_POINT and LINK

This also separates the closure-of-all-connections from the freeing of the server module so that connections can be closed at an earlier point of the shutdown sequence.

This also adds accepted-connections to the listener reference counts for a more orderly freeing of resources.

Original work by Ted Ross. Ported to amqp adaptor and obfuscated by kgiusti

---------

Co-authored-by: Ted Ross <[email protected]>
@ganeshmurthy ganeshmurthy added this to the 3.0.0 milestone Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ted-ross ted-ross

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Fixes #1456 - Implemented the administrative ACCESS_POINT and LINK kgiusti/skupper-router
2 participants
@ted-ross @ganeshmurthy