Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http1 test Timed out waiting for io.skupper.router.httpListener operStatus down #1373

Closed
kgiusti opened this issue Jan 8, 2024 · 0 comments · Fixed by #1384
Closed

http1 test Timed out waiting for io.skupper.router.httpListener operStatus down #1373

kgiusti opened this issue Jan 8, 2024 · 0 comments · Fixed by #1384
Assignees
Milestone

Comments

@kgiusti
Copy link
Contributor

kgiusti commented Jan 8, 2024

https://github.com/skupperproject/skupper-router/actions/runs/7411520029/job/20166240775#step:34:6251

From looking at the logs it appears that the router has re-connected to the python server immediately after the last test was run but before the listener socket context was closed. This results in a live connection that does not get torn down, which leave the http1 listener in the "active" state.

I think this is a timing issue in the test where the router can re-connect before the python listening socket is closed. Since the router can have only one connection active at a time I think this can be fixed if the test calls listener.shutdown(SHUT_RDWR) immediately after accepting the last server connection to the router. That should prevent a reconnection attempt from the router from succeeding before the listener socket context is closed.

@kgiusti kgiusti self-assigned this Jan 8, 2024
kgiusti added a commit to kgiusti/skupper-router that referenced this issue Jan 12, 2024
…_down

Fix prevents the router from reconnecting when the last active
connection closes by shutting down the listener socket after accepting
the last connection from the router.
@kgiusti kgiusti linked a pull request Jan 12, 2024 that will close this issue
kgiusti added a commit that referenced this issue Jan 15, 2024
Fix prevents the router from reconnecting when the last active
connection closes by shutting down the listener socket after accepting
the last connection from the router.
@ganeshmurthy ganeshmurthy added this to the 2.6.0 milestone Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants