Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Occasionally inter-router connection group correlation ids are duplicated on different routers. #1298

Closed
kgiusti opened this issue Nov 14, 2023 · 0 comments · Fixed by #1299
Closed

Occasionally inter-router connection group correlation ids are duplicated on different routers. #1298

kgiusti opened this issue Nov 14, 2023 · 0 comments · Fixed by #1299
Assignees
@kgiusti
Milestone
2.5.1

Comments

@kgiusti
Copy link
Contributor

kgiusti commented Nov 14, 2023

When I spawn a number of routers in background processes they will very occasionally generate the same group correlation discriminator values. These values should be unique per router and inter-router connector instance.

This appears to be caused by the seed value used for the random number generated. Currently this seed is generated by calling gettimeofday(). On my relatively powerful laptop occasionally routers spawned at the same time will get the same seed value.
@kgiusti kgiusti self-assigned this Nov 14, 2023
kgiusti added a commit to kgiusti/skupper-router that referenced this issue Nov 14, 2023
@kgiusti
Fixes skupperproject#1298: use entropy pool to generate PRNG seed
233f64c 
If entropy pool not available use a nano-second clock and process id
to generate the seed value.
@kgiusti kgiusti linked a pull request Nov 14, 2023 that will close this issue
Fixes #1298: use entropy pool to generate PRNG seed #1299
Merged
kgiusti added a commit that referenced this issue Nov 14, 2023
@kgiusti
Fixes #1298: use entropy pool to generate PRNG seed
f25fffe 
If entropy pool not available use a nano-second clock and process id
to generate the seed value.
@kgiusti kgiusti added this to the 2.5.1 milestone Dec 6, 2023
kgiusti added a commit to kgiusti/skupper-router that referenced this issue Dec 18, 2023
@kgiusti
Fixes skupperproject#1298: use entropy pool to generate PRNG seed
14a8650 
If entropy pool not available use a nano-second clock and process id
to generate the seed value.

(cherry picked from commit f25fffe)
kgiusti added a commit that referenced this issue Dec 18, 2023
@kgiusti
Fixes #1298: use entropy pool to generate PRNG seed
e72e399 
If entropy pool not available use a nano-second clock and process id
to generate the seed value.

(cherry picked from commit f25fffe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kgiusti kgiusti

Labels
None yet
Projects
None yet
Milestone
2.5.1
Development

Successfully merging a pull request may close this issue.

Fixes #1298: use entropy pool to generate PRNG seed kgiusti/skupper-router
1 participant
@kgiusti