Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add function names to panic handler call stack output #1254

Closed
kgiusti opened this issue Oct 11, 2023 · 0 comments · Fixed by #1256
Closed

Feature: add function names to panic handler call stack output #1254

kgiusti opened this issue Oct 11, 2023 · 0 comments · Fixed by #1256
Assignees
@kgiusti
Labels
enhancement New feature or request
Milestone
2.5.0

Comments

@kgiusti
Copy link
Contributor

kgiusti commented Oct 11, 2023

We should be able to provide the function names when outputting the call stack via the panic handler. There is this bug that currently prevents us from using this libunwind feature:

libunwind/libunwind#123

This fix should be available in the next release of libunwind (1.8?)
@kgiusti kgiusti added the enhancement New feature or request label Oct 11, 2023
@kgiusti kgiusti self-assigned this Oct 11, 2023
kgiusti added a commit to kgiusti/skupper-router that referenced this issue Oct 11, 2023
@kgiusti
Fixes skupperproject#1254: add function name to panic call stack output
7454916
kgiusti added a commit to kgiusti/skupper-router that referenced this issue Oct 11, 2023
@kgiusti
Fixes skupperproject#1254: add function name to panic call stack output
30d71b7
@kgiusti kgiusti linked a pull request Oct 12, 2023 that will close this issue
Fixes #1254: add function name to panic call stack output #1256
Merged
kgiusti added a commit to kgiusti/skupper-router that referenced this issue Oct 24, 2023
@kgiusti
Fixes skupperproject#1254: add function name to panic call stack output
812fb69
kgiusti added a commit that referenced this issue Oct 25, 2023
@kgiusti
Fixes #1254: add function name to panic call stack output (#1256)
ddfcb11
@ganeshmurthy ganeshmurthy added this to the 2.5.0 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kgiusti kgiusti

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

Fixes #1254: add function name to panic call stack output kgiusti/skupper-router
2 participants
@kgiusti @ganeshmurthy