Issue #1240: Remove bubblewrap, originally added in DISPATCH-1739

Bubblewrap (bwrap) is an unprivileged sandbox, originally meant to guard against port clashes when running tests.
During parallel test runs, each `ctest -j` subprocess would run it its own network namespace created by bwrap.

Nowadays, the port clashes in test suite were resolved, so we should not need this.
It was only enabled by default for Ubuntu jobs on GitHub actions.

.github/workflows/build.yaml

@@ -75,7 +75,6 @@ jobs:
         -DCMAKE_C_COMPILER_LAUNCHER=ccache
         -DCMAKE_CXX_COMPILER_LAUNCHER=ccache
         -DCMAKE_C_FLAGS=-DQD_MEMORY_DEBUG
-        -DUSE_BWRAP=ON
         -DRUNTIME_CHECK=${{matrix.runtimeCheck}}
         -DSANITIZE_PYTHON=OFF
         -DBUILD_BENCHMARKS=ON
@@ -253,7 +252,7 @@ jobs:
 
       - name: Install Linux runtime/test dependencies
         run: |
-          sudo apt update; sudo apt install -y libdw1 libsasl2-2 libsasl2-modules sasl2-bin libjsoncpp25 libwebsockets16 libbenchmark1 pixz bubblewrap curl ncat gdb elfutils findutils file python3-dbg
+          sudo apt update; sudo apt install -y libdw1 libsasl2-2 libsasl2-modules sasl2-bin libjsoncpp25 libwebsockets16 libbenchmark1 pixz curl ncat gdb elfutils findutils file python3-dbg
 
       - name: Unpack archive
         run: tar -I pixz -xf archive.tar.xz

tests/CMakeLists.txt

@@ -70,15 +70,7 @@ target_link_libraries(threaded_timer_test skupper-router)
 add_executable(adaptor_buffer_test adaptor_buffer_test.c)
 target_link_libraries(adaptor_buffer_test skupper-router)
 
-# Bubblewrap is an unprivileged sandboxing tool for Linux. Setting --unshare-net allows
-# running tests in parallel (the ctest -j option) without port clashes
-set(USE_BWRAP OFF CACHE BOOL "Wrap test executions with bwrap (https://github.com/containers/bubblewrap)")
-if(USE_BWRAP)
-  set(BWRAP_ARGS bwrap --bind / / --unshare-net --dev /dev --die-with-parent --)
-else()
-  set(BWRAP_ARGS "")
-endif()
-set(TEST_WRAP ${BWRAP_ARGS} ${Python_EXECUTABLE} ${CMAKE_CURRENT_BINARY_DIR}/run.py)
+set(TEST_WRAP ${Python_EXECUTABLE} ${CMAKE_CURRENT_BINARY_DIR}/run.py)
 
 add_test(unit_tests_size_10000 ${TEST_WRAP} unit_tests_size 10000)
 add_test(unit_tests_size_512   ${TEST_WRAP} unit_tests_size 512)