Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add metrics docs #251

Merged
merged 5 commits into from
Sep 16, 2024
Merged

add metrics docs #251

merged 5 commits into from
Sep 16, 2024

Conversation

pwright
Copy link
Member

@pwright pwright commented Sep 10, 2024

@pwright pwright requested a review from c-kruse September 10, 2024 18:24
c-kruse
c-kruse reviewed Sep 10, 2024
View reviewed changes
Copy link

@c-kruse c-kruse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pwright! Just a few suggestions with some context around the metrics I think we had aught to sweep under a rug.

console/metrics.adoc Outdated Show resolved Hide resolved
console/metrics.adoc Outdated Show resolved Hide resolved
console/metrics.adoc Outdated Show resolved Hide resolved
console/metrics.adoc Outdated Show resolved Hide resolved
console/metrics.adoc Outdated Show resolved Hide resolved
@pwright pwright requested a review from c-kruse September 11, 2024 17:35
c-kruse
c-kruse approved these changes Sep 12, 2024
View reviewed changes
Copy link

@c-kruse c-kruse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this Paul. Looks great!

One last call-out for posterity in case someone comes playing detective for why they can't access the metrics endpoint.

console/metrics.adoc Outdated Show resolved Hide resolved
@pwright pwright merged commit a6bc098 into skupperproject:main Sep 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-kruse c-kruse c-kruse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwright @c-kruse