Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update console #171

Merged
merged 2 commits into from
Jun 22, 2023
Merged

update console #171

merged 2 commits into from
Jun 22, 2023

Conversation

pwright
Copy link
Member

@pwright pwright commented Jun 8, 2023

No description provided.

@pwright
Copy link
Member Author

pwright commented Jun 8, 2023

addresses #154

@pwright pwright requested a review from bartoval June 8, 2023 11:23
Copy link
Member

@bartoval bartoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Cool!
I have a couple of thought.
1)We use metric for upstream for sure, but we are in the middle of discussion about use or remove prometheus for downstream. In the second case the metrics are not displayed.
2) Is there a way to highlight the use of "go to the network view"? (in rc3 it should be a button). I would like that people gain consideration about this button because improve the user experience.

modules/console/pages/flow-console.adoc Outdated Show resolved Hide resolved
@pwright
Copy link
Member Author

pwright commented Jun 22, 2023

@bartoval addressed some of your comments, but we'll need to revisit next month

@pwright pwright merged commit 969d652 into skupperproject:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants