feature request: add redis healthcheck indicator for terminus

[TrejGun]

Hello there!
Thanks for nice module.
I think it would be good to have healthcheck indicator for redis same as we have for typeorm

[MarkWarneke]

There is a sample for checking redis in the terminus repo:

https://github.com/nestjs/terminus/blob/08c0de9976c73e8d665b1f4c8a9976cb1fc02f51/sample/002-microservice-app/src/health/health.controller.ts#L21-L28

[TrejGun]

there are some more examples and better module which is actually gets updates
https://github.com/liaoliaots/nestjs-redis/blob/main/lib/health/indicators/redis.health.ts

[riteshkhatri]

@MarkWarneke
There is a sample for checking redis in the terminus repo:

https://github.com/nestjs/terminus/blob/08c0de9976c73e8d665b1f4c8a9976cb1fc02f51/sample/002-microservice-app/src/health/health.controller.ts#L21-L28

Is it working ?

[AydenZ]

@MarkWarneke There is a sample for checking redis in the terminus repo:

https://github.com/nestjs/terminus/blob/08c0de9976c73e8d665b1f4c8a9976cb1fc02f51/sample/002-microservice-app/src/health/health.controller.ts#L21-L28

Is it working ?

No, i try it ,It is not working

[peng-huang-ch]

import { parseURL } from 'ioredis/built/utils';

the ioredis seems do not support the url in the options

const redisOption = parseURL(this.configService.get('REDIS_URL'));

this.microservice.pingCheck<RedisOptions>('redis', {
	transport: Transport.REDIS,
	options: {
		...redisOption,
	},
})

[riteshkhatri]

Okay thank you

…

On Thu, 14 Jul, 2022, 1:17 pm Aaron Huang, ***@***.***> wrote: import { parseURL } from 'ioredis/built/utils'; this.microservice.pingCheck<RedisOptions>('redis', { transport: Transport.REDIS, options: { ...redisOption, }, }) — Reply to this email directly, view it on GitHub <#72 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFIM74P53XOR5RR5FNLOLG3VT7AZLANCNFSM42BVWMOQ> . You are receiving this because you commented.Message ID: ***@***.***>

[orgaizer]

Any updates here?