Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] support for
xarray
DataArray
& mtypes #3255[ENH] support for
xarray
DataArray
& mtypes #3255Changes from all commits
2fc6abe
9c12438
2d8aa9c
f1ce864
4654248
bd2ea13
ea4ba50
8ebe25b
bc60a9b
63df205
26b5227
de2ba66
98f4255
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If datatypes is refactored, then this method should be placed somewhere else. Currently similar methods are implemented in panels and tables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, indeed - too much copy-paste!
Though I would go with incurring technical debt due to priorities...
Re refactor directions:
@chrisholder started sth, but abandoned it.
#1460
Haven´t had the time to salvage it.
This would be another option:
dylan-profiler/visions#194