client: handle propfind response from Nginx dav ext #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It sends a 207 MULTISTATUS response and contains a 404 inside propstat:status instead of just returning a 404 status code. It's a bit tricky to use propstat:status for webdav4, as they may be status for properties, not the resource, and might impact other webdav servers like Owncloud/Nextcloud, as they return multiple propstats. For now, the change only affects propfind users. Also fixed `isfile` and `isdir` to not raise ResourceNotFound error, and instead just return False.
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 3311 3358 +47
Branches 191 195 +4
=========================================
+ Hits 3311 3358 +47
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It sends a 207 MULTISTATUS response and contains a 404 inside
propstat:status instead of just returning a 404 status code.
It's a bit tricky to use propstat:status for webdav4, as they may
be status for properties, not the resource, and might impact other
webdav servers like Owncloud/Nextcloud, as they return multiple
propstats.
For now, the change only affects propfind users. Also fixed
isfileandisdirto not raise ResourceNotFound error, andinstead just return False.