Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update docker/login-action action to v3 #640

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update docker/login-action action to v3 #640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@

- name: Set Base Image matrix
id: set-matrix
run: |

Check warning on line 92 in .github/workflows/build-image.yml

View workflow job for this annotation

GitHub Actions / actionlint with reviewdog 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2001:style:2:8: See if you can use ${variable//search/replace} instead [shellcheck]

Raw Output:
.github/workflows/build-image.yml:92:9: shellcheck reported issue in this script: SC2001:style:2:8: See if you can use ${variable//search/replace} instead [shellcheck]

Check warning on line 92 in .github/workflows/build-image.yml

View workflow job for this annotation

GitHub Actions / actionlint with reviewdog 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:5:11: Double quote to prevent globbing and word splitting [shellcheck]

Raw Output:
.github/workflows/build-image.yml:92:9: shellcheck reported issue in this script: SC2086:info:5:11: Double quote to prevent globbing and word splitting [shellcheck]
imgs=$(./utils/java.sh base-img | tr '\n' ' ')
imgs=$(echo "${imgs}" | sed -e 's/ /, /g')
{
Expand Down Expand Up @@ -199,15 +199,15 @@

- name: Login to ghcr.io
if: ${{ github.event_name }} != 'pull_request'
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Login to DockerHub
if: ${{ github.event_name }} != 'pull_request'
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
username: sksat
password: ${{ secrets.DOCKERHUB_TOKEN }}
Expand Down
Loading