Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

healthcheck paramerter env #193

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

healthcheck paramerter env #193

wants to merge 4 commits into from

Conversation

sksat
Copy link
Owner

@sksat sksat commented Oct 24, 2021

Fix #94

@sksat sksat added the enhancement New feature or request label Oct 24, 2021
@sksat sksat self-assigned this Oct 24, 2021
@sksat sksat force-pushed the healthcheck-param-env branch from f7e13d3 to ce25aaa Compare October 24, 2021 14:01
@sksat
Copy link
Owner Author

sksat commented Oct 24, 2021

buildxだからdocker imagesとかが効かね〜

@sksat
Copy link
Owner Author

sksat commented Oct 24, 2021

仕方ないので手元でこういうのをやる

img="sksat/papermc-docker:healthcheck-param-env-1.17.1-openjdk"
docker pull ${img}
docker images ${img}
id=$(sudo docker images -q ${img})
docker inspect ${id}

@sksat
Copy link
Owner Author

sksat commented Oct 24, 2021

いやdocker inspectしたところでイメージに焼き込まれてるパラメータは実質無意味でhealth.shでやってんの忘れてた

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@sksat sksat

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

healthcheck周りのパラメータを環境変数でやる
1 participant
@sksat