Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dark theme for the tablereport #1166

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeromedockes
Copy link
Member

rough draft to start reorganizing the colors & add a dark variant.
I'm opening the PR to have a trace of it but we don't have to use it we can start over from scratch based on #1165

@jeromedockes
Copy link
Member Author

jeromedockes commented Nov 29, 2024

the colors are very random and need to be changed but I think at this point the report should be readable both in light & dark modes

screenshot_2024-11-29T09:47:32+01:00

(see for example the rendered doc )

@GaelVaroquaux
Copy link
Member

Did you try it with various vscode dark theme (there are a few)?

@jeromedockes
Copy link
Member Author

I would rather not try to match the exact theme with a finer granularity than dark/light. IMO we should hard code a full set of colors for light mode and for dark mode and just match the mode rather than reuse colors from a vscode theme. because vscode is just one of the many places report can be displayed, and also I assume that as in any editor there is a myriad of themes and each user can come up with their own. so I think if we try to reuse colors from vscode themes we can end up having to maintain many variants, spend time checking them every time we change something, and most importantly risk having some parts unreadable due to low contrast in some environments

@GaelVaroquaux
Copy link
Member

GaelVaroquaux commented Nov 29, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants