Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute n_unique for all columns in tablereport #1154

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

jeromedockes
Copy link
Member

fixes #1070

ATM the tablereport only computes the number of unique values for categorical columns.
with this pr it does it for all columns

@jeromedockes jeromedockes marked this pull request as ready for review November 22, 2024 13:46
@jeromedockes jeromedockes added this to the 0.3.2 milestone Nov 22, 2024
Copy link
Member

@Vincent-Maladiere Vincent-Maladiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@Vincent-Maladiere Vincent-Maladiere merged commit d0658c6 into skrub-data:main Nov 24, 2024
25 checks passed
@jeromedockes jeromedockes deleted the fix-1070 branch November 25, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TableReport Stats doesn't display nunique Integers
2 participants