-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sorting of the summary statistics table #1068
Merged
Vincent-Maladiere
merged 12 commits into
skrub-data:main
from
jeromedockes:sortable-stats-table
Sep 16, 2024
Merged
Add sorting of the summary statistics table #1068
Vincent-Maladiere
merged 12 commits into
skrub-data:main
from
jeromedockes:sortable-stats-table
Sep 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
Nice addition, is it possible to remove the shadow around the buttons? |
@Vincent-Maladiere I removed the shadows and also changed the icons for something more explicit. it should be ok now |
Vincent-Maladiere
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jeromedockes
added a commit
to jeromedockes/skrub
that referenced
this pull request
Sep 25, 2024
* add sorting of the summary statistics table * _ * buttons display * _ * _ * _ * _ * changelog + formatting * remove shadow below buttons * add tests * better icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is now possible to sort the table in the "stats" tab panel eg from columns with fewest null values to most null values
WIP: