Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrow key navigation in sample table #1065

Merged
merged 10 commits into from
Sep 12, 2024

Conversation

jeromedockes
Copy link
Member

@jeromedockes jeromedockes commented Sep 10, 2024

arrow keys or hjkl to move around, Esc to deselect a cell, Ctr-c to copy

also now the column headers can be selected

also events with a modifier key pressed down (eg Alt+right arrow) are now ignored

Copy link
Member

@Vincent-Maladiere Vincent-Maladiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@jeromedockes jeromedockes merged commit d515ebb into skrub-data:main Sep 12, 2024
22 checks passed
@jeromedockes jeromedockes deleted the sample-table-kbd branch September 12, 2024 13:28
Shree7676 pushed a commit to Shree7676/skrub that referenced this pull request Sep 12, 2024
Shree7676 added a commit to Shree7676/skrub that referenced this pull request Sep 12, 2024
jeromedockes added a commit to jeromedockes/skrub that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants