-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seven/add shipping cost attribute to order #216
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have revert commits, maybe we should remove the original commits and reverts if they are not needed
@@ -23,6 +23,7 @@ Name | Type | Value | Description | |||
`fulfilled_by_skroutz` | Boolean | | Whether the order is fulfilled by skroutz | |||
`fbs_delivery_note` | String | | Order's delivery note from warehouse for orders that are fulfilled by Skroutz | |||
`store_pickup` | Boolean | | Whether the order will be picked up by the user at the store | |||
`shipping_cost` | Double | | The order's shipping cost in euros (only for Fulfilled by Merchant orders, `0` for all other orders) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we changed that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks! Fixed and force pushed again.
479465a
to
b8a49fb
Compare
b8a49fb
to
c453651
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJK
Relates to https://phabricator.skroutz.gr/T145432