More chai/sinon patches (take 2) #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* check for spread call expressions with context identifier
* change sinon .mockImplementation to support any[]
* support .contains with jsx element
* support .toContain for .text()
* handle .toHavePropery('callCount', n)
Codecov Report
@@ Coverage Diff @@
## main #322 +/- ##
==========================================
- Coverage 92.22% 92.09% -0.14%
==========================================
Files 26 26
Lines 1852 1872 +20
Branches 385 392 +7
==========================================
+ Hits 1708 1724 +16
Misses 102 102
- Partials 42 46 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@skovhus this is #315 without amending the old commit.
I wrote https://github.com/danbeam/jest-codemods/commit/171f96d46a9d1225abafbb3aa87995aeb9a16d46 chronologically before #291 but forgot to upstream it (whoops) so I'm doing that now.
@catc wrote https://github.com/danbeam/jest-codemods/commit/d2b3d76e3e14772b83bbc07dcd796ea5193f2c53 and I wrote https://github.com/danbeam/jest-codemods/commit/ddc2c66b16d4493573839f55d79223ecd3e6f1d6. cc @lencioni