Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve randomness (#101) #103

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Conversation

hhartzer
Copy link
Contributor

@hhartzer hhartzer commented Mar 7, 2024

Fixes: #101

shortuuid/main.py Outdated Show resolved Hide resolved
skorokithakis
skorokithakis previously approved these changes Mar 8, 2024
@hhartzer
Copy link
Contributor Author

hhartzer commented Mar 8, 2024

That's much more concise. Thank you for reviewing!

@skorokithakis
Copy link
Owner

Thanks for the code! Unfortunately I need to figure out ruff before I can merge, I screwed some stuff up.

@hhartzer
Copy link
Contributor Author

hhartzer commented Mar 8, 2024

No problem! Ruff is great and should be worth it in the end.

Copy link
Owner

@skorokithakis skorokithakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@skorokithakis skorokithakis merged commit 5dda33e into skorokithakis:master Mar 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The first character of shortuuid.random() strings is not fully random
2 participants