Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This commit fixes the release/deploy script #987

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

ottonemo
Copy link
Member

Before it was not possible to execute this script without errors as the conda update was broken. I moved the activation of the conda env to conda run which is apparently the recommended way.

Before it was not possible to execute this script without errors as
the conda update was broken. I moved the activation of the conda
env to `conda run` which is apparently the recommended way.
@ottonemo ottonemo requested a review from BenjaminBossan June 26, 2023 15:32
Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is annoying, not sure why it's necessary. It doesn't affect how the script is run, so we can merge it, but I dislike it when the bash script looks very different from how the commands would be run by hand :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants