Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add collecting of cluster wide resources #93

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Add collecting of cluster wide resources #93

merged 1 commit into from
Jun 4, 2024

Conversation

kornys
Copy link
Member

@kornys kornys commented Jun 3, 2024

Description

Addded ability to collect also cluster wide resources
close #92

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit/integration tests pass locally with my changes

@kornys kornys added the enhancement New feature or request label Jun 3, 2024
@kornys kornys self-assigned this Jun 3, 2024
@github-actions github-actions bot requested review from Frawless and im-konge June 3, 2024 10:54
im-konge
im-konge reviewed Jun 3, 2024
View reviewed changes
Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments/suggestions. Thanks a lot :)

test-frame-log-collector/src/main/java/io/skodjob/testframe/LogCollector.java Outdated Show resolved Hide resolved
test-frame-log-collector/src/main/java/io/skodjob/testframe/LogCollector.java Outdated Show resolved Hide resolved
test-frame-log-collector/src/main/java/io/skodjob/testframe/LogCollector.java Outdated Show resolved Hide resolved
test-frame-log-collector/src/main/java/io/skodjob/testframe/LogCollector.java Outdated Show resolved Hide resolved
test-frame-log-collector/src/test/java/io/skodjob/testframe/LogCollectorIT.java Show resolved Hide resolved
test-frame-log-collector/src/test/java/io/skodjob/testframe/LogCollectorIT.java Show resolved Hide resolved
test-frame-log-collector/src/main/java/io/skodjob/testframe/LogCollectorBuilder.java Outdated Show resolved Hide resolved
@kornys kornys force-pushed the cluster-wide-colect branch from 7da7a4c to 2801d1c Compare June 4, 2024 05:32
@kornys kornys merged commit 2c0cbbd into main Jun 4, 2024
6 checks passed
@kornys kornys deleted the cluster-wide-colect branch June 4, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frawless Frawless Frawless approved these changes

@im-konge im-konge im-konge approved these changes

Assignees

@kornys kornys

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: LogCollector ability to collect cluster wide resoruces
3 participants
@kornys @Frawless @im-konge