Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LogCollector #88

Merged
merged 7 commits into from
May 31, 2024
Merged

Implement LogCollector #88

merged 7 commits into from
May 31, 2024

Conversation

im-konge
Copy link
Member

@im-konge im-konge commented May 28, 2024 •
edited
Loading

Description

This PR implements LogCollector component, which is/should be used for collecting logs, events, Pod descriptions, and finally resource YAMLs for all resources that user specifies.

The LogCollector is able to collect logs from one namespace, multiple namespaces, or users can pick Namespaces that matches some LabelSelector.

Closes #7

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit/integration tests pass locally with my changes

@github-actions github-actions bot requested review from Frawless and kornys May 28, 2024 19:01
@kornys
Copy link
Member

kornys commented May 29, 2024

I also see that tests are not triggered in github pipelines

im-konge added 2 commits May 29, 2024 18:27
@im-konge
init
85db1e0 
Signed-off-by: Lukas Kral <[email protected]>

Implement LogCollector

Signed-off-by: Lukas Kral <[email protected]>

private constructor LogCollectorUtils

resolve comments - running tests, licenses and release stuff, test visual separators

Signed-off-by: Lukas Kral <[email protected]>
@im-konge
add test to examples, readme, fix everything
8793956 
Signed-off-by: Lukas Kral <[email protected]>
@im-konge im-konge requested a review from kornys May 30, 2024 16:08
@im-konge im-konge requested a review from kornys May 30, 2024 16:50
@im-konge im-konge added this to the 0.1.0 milestone May 31, 2024
@im-konge im-konge added the enhancement New feature or request label May 31, 2024
@im-konge
add additional folder path to the logcollector instead of changing th…
c34440f 
…e root folder path parameter

Signed-off-by: Lukas Kral <[email protected]>
@im-konge
MO's comment
1afb14b 
Signed-off-by: Lukas Kral <[email protected]>
@im-konge im-konge merged commit 2047436 into main May 31, 2024
6 checks passed
@im-konge im-konge deleted the log-collector branch May 31, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@see-quick see-quick see-quick approved these changes

@kornys kornys kornys approved these changes

@Frawless Frawless Frawless approved these changes

Assignees

@im-konge im-konge

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

Add LogCollector with its tests
4 participants
@im-konge @kornys @Frawless @see-quick