Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify namespaced and non namespaced ResoruceType API #161

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

kornys
Copy link
Member

@kornys kornys commented Aug 8, 2024

Description

Remove NamespacedResoruceType and use unified ResoruceType interface.

Type of Change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit/integration tests pass locally with my changes

@kornys kornys added this to the 0.4.0 milestone Aug 8, 2024
@kornys kornys self-assigned this Aug 8, 2024
@kornys kornys linked an issue Aug 8, 2024 that may be closed by this pull request
@github-actions github-actions bot requested review from Frawless and im-konge August 8, 2024 07:08
@kornys kornys merged commit c6b483d into main Aug 8, 2024
7 checks passed
@kornys kornys deleted the clean-rt-api branch August 8, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX]: NamespacedResourceItem does not need to override useless methods
3 participants