Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use log4j2 and slf4j properly, add maven-dependency plugin #149

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

Frawless
Copy link
Member

Description

This PR use slf4j properly in our implementation. It will now allows to users to specify their own logger implementation. In the tests we use log4j-slf4j2-impl.

I also added maven-dependency-plugin to remove unneeded dependencies

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit/integration tests pass locally with my changes

@Frawless Frawless merged commit 7f7377a into main Jul 23, 2024
7 checks passed
@Frawless Frawless deleted the fix-loggers branch July 23, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants