Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MustGather from test-frame #142

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Remove MustGather from test-frame #142

merged 1 commit into from
Jul 16, 2024

Conversation

kornys
Copy link
Member

@kornys kornys commented Jul 16, 2024

Description

Since configuration seems to be tricky and it requires more and more complexity there is no added value for end user of test-frame. Current implementation of using LogCollector ad-hoc or based on event configured by end-user is most productive and adds full power.
So from my POV it would be better to remove MustGather and leave config on end-user.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit/integration tests pass locally with my changes

@kornys kornys self-assigned this Jul 16, 2024
@github-actions github-actions bot requested review from Frawless and im-konge July 16, 2024 08:52
@kornys kornys changed the title Remove MutsGather from test-frame Remove MustGather from test-frame Jul 16, 2024
@kornys kornys merged commit 503840b into main Jul 16, 2024
7 checks passed
@kornys kornys deleted the remove-must-gather branch July 16, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants