Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GlobalLogCollector to MustGather and use only one callback #133

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

kornys
Copy link
Member

@kornys kornys commented Jul 11, 2024

Description

GlobalLogCollector name is weird so we decided to rename it to MustGather

Type of Change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit/integration tests pass locally with my changes

@kornys kornys added this to the 0.2.0 milestone Jul 11, 2024
@kornys kornys self-assigned this Jul 11, 2024
@github-actions github-actions bot requested review from Frawless and im-konge July 11, 2024 08:43
kornys added 2 commits July 11, 2024 10:46
Signed-off-by: David Kornel <[email protected]>
Signed-off-by: David Kornel <[email protected]>
@kornys kornys merged commit 154ce30 into main Jul 11, 2024
6 checks passed
@kornys kornys deleted the must-gather branch July 11, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants