Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics collector returns formatted data in POJO #120

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Metrics collector returns formatted data in POJO #120

merged 1 commit into from
Jul 3, 2024

Conversation

kornys
Copy link
Member

@kornys kornys commented Jul 3, 2024

Description

MC returns formatted data in POJO of metrics.

Type of Change

Please delete options that are not relevant.

  • New feature (breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit/integration tests pass locally with my changes

@kornys kornys added this to the 0.2.0 milestone Jul 3, 2024
@kornys kornys self-assigned this Jul 3, 2024
@github-actions github-actions bot requested review from Frawless and im-konge July 3, 2024 10:43
@kornys kornys requested a review from see-quick July 3, 2024 10:44
Copy link
Contributor

@obabec obabec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kornys kornys added the enhancement New feature or request label Jul 3, 2024
@kornys kornys merged commit f587b90 into main Jul 3, 2024
7 checks passed
@kornys kornys deleted the MC-POJO branch July 3, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: MetricsCollector should have return formatted metrics data instead of string
4 participants