Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply checkstyle to test modules + fix checkstyle issues #112

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

kornys
Copy link
Member

@kornys kornys commented Jun 27, 2024

Description

Require checkstyle also on all test modules

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit/integration tests pass locally with my changes

@kornys kornys added this to the 0.2.0 milestone Jun 27, 2024
@kornys kornys self-assigned this Jun 27, 2024
@kornys kornys force-pushed the checkstyle-test-fix branch from 9cbab01 to 1aa3a42 Compare June 27, 2024 11:33
@kornys kornys marked this pull request as ready for review June 27, 2024 11:33
@github-actions github-actions bot requested review from Frawless and im-konge June 27, 2024 11:33
@kornys
Copy link
Member Author

kornys commented Jun 27, 2024

@Frawless @im-konge
Quaestion is :)
What is our default indent settings
I have in IDEA
4
4
8

Lukas has I think
4
4
4

not sure what is better
If we decide I can in this PR also change indentation in rest of the files

@im-konge
Copy link
Member

As I mentioned before, 4,4,4 is natural for me, the 8 spaces for the continuous lines is a bit weird for me. And I think that it should be same across everything (I mean the 4 spaces).

@kornys
Copy link
Member Author

kornys commented Jun 27, 2024

As I mentioned before, 4,4,4 is natural for me, the 8 spaces for the continuous lines is a bit weird for me. And I think that it should be same across everything (I mean the 4 spaces).

ok then I can require it and change it in my IDEA

@kornys kornys force-pushed the checkstyle-test-fix branch from 1aa3a42 to 5cccd8f Compare June 27, 2024 15:30
@kornys kornys merged commit 2f4e31a into main Jun 28, 2024
6 checks passed
@kornys kornys deleted the checkstyle-test-fix branch June 28, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add requirements of checkstyle also into all test modules.
3 participants