Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic example test for MetricsCollector #106

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Add basic example test for MetricsCollector #106

merged 1 commit into from
Jun 25, 2024

Conversation

kornys
Copy link
Member

@kornys kornys commented Jun 25, 2024

Description

Add simple example test of using metrics collector in to our examples

close #67

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit/integration tests pass locally with my changes

@kornys kornys self-assigned this Jun 25, 2024
@github-actions github-actions bot requested review from Frawless and im-konge June 25, 2024 10:09
Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should maybe apply the checkstyle check for the tests as well -> because it little bit differs with how we are styling the code and the tests.
But something for different PR, thanks for this :)

@kornys kornys merged commit 477a9df into main Jun 25, 2024
7 checks passed
@kornys kornys deleted the mc-test branch June 25, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a system-test level tests covering MetricsCollector component
3 participants