Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix suggestion about printStackTrace and use Logger instead #104

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Fix suggestion about printStackTrace and use Logger instead #104

merged 1 commit into from
Jun 17, 2024

Conversation

kornys
Copy link
Member

@kornys kornys commented Jun 17, 2024

Description

Fix logging issues about stack trace and use logger instead of printStackTrace

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit/integration tests pass locally with my changes

@kornys kornys added this to the 0.2.0 milestone Jun 17, 2024
@kornys kornys self-assigned this Jun 17, 2024
@github-actions github-actions bot requested review from Frawless and im-konge June 17, 2024 15:20
@kornys kornys merged commit 669835f into main Jun 17, 2024
7 checks passed
@kornys kornys deleted the logger-stack-trace branch June 17, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@im-konge im-konge im-konge approved these changes

@Frawless Frawless Frawless approved these changes

Assignees

@kornys kornys

Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kornys @Frawless @im-konge