[metrics collector] fix timeout + more verbose in case of failure

Signed-off-by: see-quick <[email protected]>
skodjob · Jun 6, 2024 · 6759581 · 6759581
1 parent d6f7fbc
commit 6759581
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/test-frame-metrics-collector/src/main/java/io/skodjob/testframe/MetricsCollector.java b/test-frame-metrics-collector/src/main/java/io/skodjob/testframe/MetricsCollector.java
@@ -440,11 +440,13 @@ public final void collectMetricsFromPods(long timeoutDuration) {
                         if (metricsData.isEmpty()) {
                             status.setMessage("No pods found or no metrics available from pods.");
                             status.setType(MetricsCollectionStatus.Type.NO_DATA);
+                            LOGGER.error("Metrics collection failed: {}", status.getMessage());
                             return false;
                         }
                         if (metricsData.values().stream().anyMatch(String::isEmpty)) {
                             status.setMessage("Incomplete metrics data collected.");
                             status.setType(MetricsCollectionStatus.Type.INCOMPLETE_DATA);
+                            LOGGER.error("Metrics collection incomplete: Some pods returned empty metrics.");
                             return false;
                         }
                         this.collectedData = metricsData;
@@ -453,12 +455,14 @@ public final void collectMetricsFromPods(long timeoutDuration) {
                         status.setMessage(e.getMessage());
                         status.setType(MetricsCollectionStatus.Type.ERROR);
                         status.setException(e);
+                        LOGGER.error("Error during metrics collection: {}", status.getMessage(), e);
                         return false;
                     }
                 },
-                () -> LOGGER.error("Failed to collect metrics: {}", status.getMessage())
+                () -> LOGGER.error("Failed to collect metrics within the allowed time: {}", status.getMessage())
             );
         } catch (WaitException we) {
+            LOGGER.error("Metrics collection terminated due to timeout: {}", we.getMessage());
             throw determineExceptionFromStatus(status);
         }
     }
@@ -521,7 +525,7 @@ public void setType(Type type) {
      *                                    collection logic.
      */
     public final void collectMetricsFromPods() throws MetricsCollectionException {
-        collectMetricsFromPods(Duration.ofSeconds(TestFrameConstants.GLOBAL_TIMEOUT_MEDIUM).toMillis());
+        collectMetricsFromPods(TestFrameConstants.GLOBAL_TIMEOUT_MEDIUM);
     }
 
     /**