Patch for Django 4.1 support. #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: AttributeError: 'UserAgentMiddleware' object has no attribute '_is_coroutine'
sarahboyce
force-pushed
the
user-agent-coroutine
branch
from
7bebb53
to
015d0f3
Compare
pcraciunoiu
reviewed
Sep 27, 2022
| @@ -1,10 +1,10 @@ | |||
| from django_seo_js import settings | |||
| from django_seo_js.backends import SelectedBackend | |||
| from django_seo_js.backends import SelectedBackendMixin | |||
There was a problem hiding this comment.
Why did this need to be switched to use the mixin? It was using the backend before. Does the new SelectedBackend require get_response because of the middleware mixin?
There was a problem hiding this comment.
Yes exactly 👍
The django MiddlewareMixin means SelectedBackend requires get_response, so we can't do SelectedBackend() without passing something in.
pcraciunoiu
approved these changes
Sep 27, 2022
|
Thanks @sarahboyce released as 0.4.1. Please test thoroughly. |
|
@skoczen what do you think about converting this to an org? I help maintain this https://github.com/django-ses/django-ses and it'd be easier to set up Actions for deploys if I had access |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pcraciunoiu I'm so so sorry, it looks like there was another change required that I missed
SelectedBackendwas missing calling the init of it's parent (and so was missing this_is_coroutineadded in the django async work)But doing this meant you cannot just do
SelectedBackend()asget_responseis required, so I have created aSelectedBackendMixinwhich can be called in the helper functionWould you be able to review and maybe issue a patch release 🙏